Skip to content

Validate PostHog cursors before event writes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 1 commit into from
Jul 19, 2026
Merged

Validate PostHog cursors before event writes #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/importer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,19 +1907,22 @@ impl Importer {
}
}

let events = self.filter_existing(events).await?;
let projected_events = self.summary.events + events.len();
let requires_cursor = event_page_requires_cursor(
count,
limit,
self.next_limit(self.config.max_events, projected_events),
);
let next_cursor = validated_event_page_cursor(requires_cursor, next_cursor)?;

let previous_events = self.summary.events;
let sent = self.send(events).await?;
let sent = self.send_filtered(events).await?;
self.summary.events += sent;
if previous_events / PROGRESS_INTERVAL < self.summary.events / PROGRESS_INTERVAL {
eprintln!("PostHog import progress: events={}", self.summary.events);
}

let requires_cursor = event_page_requires_cursor(
count,
limit,
self.next_limit(self.config.max_events, self.summary.events),
);
let next_cursor = validated_event_page_cursor(requires_cursor, next_cursor)?;
if !requires_cursor {
break;
}
Expand Down Expand Up @@ -2048,6 +2051,10 @@ impl Importer {

async fn send(&mut self, items: Vec<ImportBatchItem>) -> Result<usize, ImportError> {
let items = self.filter_existing(items).await?;
self.send_filtered(items).await
}

async fn send_filtered(&mut self, items: Vec<ImportBatchItem>) -> Result<usize, ImportError> {
if items.is_empty() {
return Ok(0);
}
Expand Down
Loading