Fix workbench demo launch#142
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5728a87038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| from sidemantic.workbench.app import SidequeryWorkbench | ||
| from sidemantic.workbench.validation_app import ValidationApp | ||
| WORKBENCH_EXTRA_INSTALL = "uvx --from 'sidemantic[workbench]' sidemantic workbench --demo" |
There was a problem hiding this comment.
When users follow this new hint outside the dev environment, sidemantic[workbench] installs Textual/plotting only; it does not install lkml (see pyproject.toml workbench vs lookml extras). The packaged demo includes examples/multi_format_demo/lookml/orders.lkml, and load_from_directory() parses .lkml files through LookMLAdapter, which requires lkml; without it the orders model is skipped while the starter queries in sidemantic/workbench/examples.py all reference orders.*. The demo therefore launches with the suggested command but the bundled queries fail, so the hint/README command should include the lookml extra as well, e.g. sidemantic[workbench,lookml].
Useful? React with 👍 / 👎.
1 participant
Fixes #139.
This updates the demo docs to install the workbench extra with uvx, lazy-loads the TUI dependencies so missing extras produce a clear install hint instead of an import traceback, and covers the demo starter queries with a regression test.
Validated with the required local lint, format, and test suite, plus a headless workbench demo smoke test.