Skip to content

Conversation

@mPokornyETM
Copy link
Collaborator

Request for a change on public repository on CtrlppCheck

Basic information

Till checking my private development projects I found some unexpected warnings related to UTF8 / ISO encoding.
This changes eliminates the warnings as well and also provide new check, if the function fileToString() is used in correct way.

Technical information

Testing done

My local automated tests execution is OK.

Proposed upgrade guidelines

N/A

Localizations

N/N

Submitter checklist

  • [ ] The Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood.
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • There is automated testing or an explanation that explains why this change has no tests.
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] Any localizations are transferred to /msg/ files.
  • Automated tests has been executed and valid

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • C++ and Control(++) code changes are tested by automated test.
  • WinCC OA guidelines for C++ and Control(++) coding have been met.
  • Result of pipeline build proving error/warning free code.
  • Result of automatic tests proving regression free.

@mPokornyETM mPokornyETM added the enhancement New feature or request label Jan 3, 2024
@dhoegerlETM dhoegerlETM merged commit 268eb92 into siemens:main Jan 8, 2024
@mPokornyETM mPokornyETM deleted the utf8-warnings branch January 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants