refactor(tree): move effect code back to updateContextMenuItem#1804
Merged
chintankavathia merged 1 commit intomainfrom Apr 2, 2026
Merged
refactor(tree): move effect code back to updateContextMenuItem#1804chintankavathia merged 1 commit intomainfrom
chintankavathia merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the initialization of context menu items by moving an effect block from the constructor into a new private method. Feedback indicates that using effect() for state propagation violates the repository style guide (Rule 38), which recommends using computed() or a reactive approach instead. Additionally, the reviewer noted a risk of creating redundant effects if the method is called multiple times and suggested correcting a naming inconsistency between the method and the signal it updates.
projects/element-ng/tree-view/si-tree-view-item/si-tree-view-item.component.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: