Skip to content

build(npm): centralize node and npm version#1914

Open
spliffone wants to merge 1 commit intomainfrom
build/centralize-node-version
Open

build(npm): centralize node and npm version#1914
spliffone wants to merge 1 commit intomainfrom
build/centralize-node-version

Conversation

@spliffone
Copy link
Copy Markdown
Member

@spliffone spliffone commented Apr 21, 2026

@spliffone spliffone requested a review from a team as a code owner April 21, 2026 15:06
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js version to 24.15.0 and introduces Renovate rules for automated LTS tracking. Feedback includes synchronizing @types/node with the engine version, pinning dependency versions, and using the packageManager field in package.json for centralized versioning. It is also suggested to include @types/node in the Renovate LTS tracking logic.

Comment thread package.json
Comment thread renovate.json5 Outdated
@spliffone spliffone force-pushed the build/centralize-node-version branch from b900102 to 22e885e Compare April 21, 2026 15:56
@spliffone spliffone added the enhancement Topics that make the project better label Apr 21, 2026
@spliffone spliffone added this to the 49.x milestone Apr 21, 2026
Comment thread package.json
"node": "^24.0.0",
"node": "^24.15.0",
"yarn": "Please use NPM to install dependencies",
"npm": "11"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also fix this? I guess just to the version bundled with the respective node version?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit uncertain we need it since node is bundled with npm already so I would rather vote to drop this entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Topics that make the project better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent NPM version missmatch on release branches

2 participants