refactor(phone-number): convert phoneNumber and selectedCountry to signals#2254
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the SiPhoneNumberInputComponent to use Angular Signals for state management, converting selectedCountry and phoneNumber into signals and updating the template and component logic accordingly. The review feedback focuses on ensuring proper reactivity and safety when working with these signals. Specifically, it recommends configuring the phoneNumber signal with a custom equality check to handle in-place mutations of the mutable PhoneNumber class, extracting signals into local variables to avoid multiple reads and unsafe non-null assertions, and explicitly calling .set() after mutating the phone number object to trigger reactivity.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
14f4203 to
da7b475
Compare
da7b475 to
f5436c6
Compare
f5436c6 to
bd3f759
Compare
…o signals This is a preparation so we can convert other fields to computed later in a follow-up PR.
bd3f759 to
13045c2
Compare
This is a preparation so we can convert other fields to computed later in a follow-up PR.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: