Skip to content

Python(fix): cache boundary resolution to include ns - #776

Merged
alexluck-sift merged 5 commits into
mainfrom
al/python/fix-cache-boundary-resolution
Sep 3, 2026
Merged

Python(fix): cache boundary resolution to include ns#776
alexluck-sift merged 5 commits into
mainfrom
al/python/fix-cache-boundary-resolution

Conversation

@alexluck-sift

@alexluck-sift alexluck-sift commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator
  • The channel data cache stored segment bounds as datetime, truncating the nanosecond timestamps that getData supports. Every get data produced a UserWarning: Discarding nonzero nanoseconds in conversion once per channel, and then incorrectly truncated the precision when stored in cache. Bounds are now pd.Timestamp, and get_data / get_data_as_arrow accept pd.Timestamp bounds that keep their nanoseconds through to the request.
  • Folds two duplicate protobuf converters into to_timestamp_pb, so the export, run, rule and tag paths stop silently flooring to microseconds.

@alexluck-sift
alexluck-sift force-pushed the al/python/fix-cache-boundary-resolution branch from 705867b to f2a0642 Compare September 3, 2026 16:02
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-776/

Deployed from 8a6fa62. The link may take up to a minute to become live as GitHub Pages propagates.

@alexluck-sift
alexluck-sift marked this pull request as ready for review September 3, 2026 16:36
Comment thread python/lib/sift_py/data/service.py Outdated
@alexluck-sift
alexluck-sift merged commit 1622686 into main Sep 3, 2026
26 checks passed
@alexluck-sift
alexluck-sift deleted the al/python/fix-cache-boundary-resolution branch September 3, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants