Add support for repository topics #859
Conversation
Adds support for listing the topics of a repository, as described in https://developer.github.com/v3/repos/#list-all-topics-for-a-repository, or replacing them with a new list of topics, as described instead in https://developer.github.com/v3/repos/#replace-all-topics-for-a-repository.
jacquerie
force-pushed
the
add-support-for-repository-topics
branch
from
447c61c to
07a0b4a
Compare
| .. attribute:: names | ||
|
|
||
| The names of the topics. | ||
| """ |
There was a problem hiding this comment.
WDYT of adding an __iter__ and a __len__, so that essentially Topics becomes a facade of its names attribute? I didn't do it outright as this pattern (AFAICT) is not used elsewhere in the code base.
There was a problem hiding this comment.
I'd rather not. As you mentioned we don't have that precedent anywhere else.
Further, if GitHub adds more attributes to this endpoint (which I'm guess they will based on the structure of the JSON [1]) then iterating over the Topics object will be more confusing.
It almost feels like we shouldn't have an object for this, but again, I suspect they'll be expanding the response without telling anyone.
[1] I'm assuming that they haven't given up on consistency for the API behaviour which is what this looks like on first blush.
There was a problem hiding this comment.
Further, if GitHub adds more attributes to this endpoint [...] then iterating over the Topics object will be more confusing.
Good point, that's an excellent argument for avoiding this magic 👍
|
Build succeeded (third-party-check pipeline).
|
|
Thank you! This is fantastic! |
2 participants
Adds support for listing the topics of a repository, as described in
https://developer.github.com/v3/repos/#list-all-topics-for-a-repository,
or replacing them with a new list of topics, as described instead in
https://developer.github.com/v3/repos/#replace-all-topics-for-a-repository.