test: add GraphSettings isolation fixture and edge case tests#3
Merged
test: add GraphSettings isolation fixture and edge case tests#3
Conversation
- Add conftest.py with autouse fixtures to reset GraphSettings and clear singleton cache between tests, preventing cross-test contamination - Add singleton tests: identity, distinctness, cross-class isolation - Add trainer tests: error handling, merge exhaustion, single node, multiple graphs, readable merge output - Add characters() bytes roundtrip tests for ASCII and non-ASCII Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conftest.pywith autouse fixtures that resetGraphSettingsand clear singleton cache between testsWhat improved
GraphSettingsmutations to subsequent tests (was a subtle source of order-dependent failures)Test plan
ruff check .passes🤖 Generated with Claude Code