ci: fix CI by adding examples deps, add pytest-timeout (5 min)#4
Merged
ci: fix CI by adding examples deps, add pytest-timeout (5 min)#4
Conversation
3 tasks
- Add [examples] optional dependency group with datasets, tokenizers, transformers so CI can install them via .[dev] - Add pytest-timeout with 300s default to prevent runaway training - Fix lint issues (unused import, unnecessary encoding arg) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
force-pushed
the
feat/training-timeout
branch
from
0eb4dda to
87d4be5
Compare
AmitMY
commented
Apr 8, 2026
Contributor
Author
AmitMY
left a comment
AmitMY
left a comment
There was a problem hiding this comment.
E ModuleNotFoundError: No module named 'graphviz'
Contributor
Author
|
E ModuleNotFoundError: No module named 'graphviz' |
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Contributor
Author
|
Fixed in #23 — added |
draw.py imports graphviz and Pillow but they weren't in any dependency group, causing ModuleNotFoundError in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
added a commit
that referenced
this pull request
Apr 8, 2026
- Add graphviz + Pillow to [draw] optional deps, include in [dev] (#4) - Simplify super_bpe.py to use train_bne_tokenizer for phase 1 (#6) - Add comment explaining phase 2 merge replay in super BPE (#6) - Test actual expected merge values for boundless BPE (#6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[examples]optional dependency group (datasets,tokenizers,transformers) and include it in[dev]so CI installs everything needed for tokenizer testspytest-timeoutwith 300s (5 min) default to prevent runaway training in testsStacked on #3 and #2.
What improved
ModuleNotFoundError: No module named 'datasets')Test plan
ruff check .passes🤖 Generated with Claude Code