[mod_av] changes to solve some video conference recording issues#591
[mod_av] changes to solve some video conference recording issues#591blackhorse-reddog wants to merge 4 commits intosignalwire:masterfrom
Conversation
Modifications in av_format.c: s->url should be created by av_strdup instead of strdup, because ffmpeg's util.c uses av_freep(&s->url); to free it. Currently it can cause a crash. If codec_id is AV_CODEC_IP_MPEG4 (which is choosen by ffmpeg if the file extension is mp4), timebase denominator should be 48000 instead of 90000: "timebase 1/90000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535"
…er to prevent the floor state from being stolen.
|
av part LGTM. not sure the recorder of |
|
"not sure the recorder of conference_video_set_floor_holder" |
s->url should be created by av_strdup instead of strdup, because ffmpeg's util.c uses av_freep(&s->url); to free it. Currently it can cause a crash.
If codec_id is AV_CODEC_IP_MPEG4 (which is choosen by ffmpeg if the file extension is mp4), timebase denominator should be 48000 instead of 90000: "timebase 1/90000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535"