Skip to content

Update strum to 0.27#8564

Merged
mergify[bot] merged 2 commits intosigp:unstablefrom
macladson:strum-update
Dec 15, 2025
Merged

Update strum to 0.27#8564
mergify[bot] merged 2 commits intosigp:unstablefrom
macladson:strum-update

Conversation

@macladson
Copy link
Copy Markdown
Member

Issue Addressed

#8547

Proposed Changes

Update our strum dependency to 0.27. This unifies our strum dependencies and removes our duplication of strum (and by extension, strum_macros).

@macladson macladson added ready-for-review The code is ready for review dependencies Pull requests that update a dependency file labels Dec 11, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Dec 11, 2025

Some required checks have failed. Could you please take a look @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Dec 11, 2025
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 15, 2025
Copy link
Copy Markdown
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V nice!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 15, 2025
@mergify mergify bot added the queued label Dec 15, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Dec 15, 2025

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 7c09843

This pull request spent 32 minutes 32 seconds in the queue, including 31 minutes 19 seconds running CI.
The checks were run on draft #8578.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Dec 15, 2025
@mergify mergify bot added dequeued and removed queued labels Dec 15, 2025
@michaelsproul
Copy link
Copy Markdown
Member

@mergify requeue

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 15, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 15, 2025

Merge Queue Status

✅ The pull request has been merged at 7c09843

This pull request spent 38 minutes 31 seconds in the queue, including 37 minutes 13 seconds running CI.
The checks were run on draft #8579.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added queued and removed dequeued labels Dec 15, 2025
mergify bot added a commit that referenced this pull request Dec 15, 2025
@mergify mergify bot merged commit 6a3a325 into sigp:unstable Dec 15, 2025
36 checks passed
@mergify mergify bot removed the queued label Dec 15, 2025
@macladson macladson deleted the strum-update branch December 16, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants