[Merged by Bors] - Remove block clone #1448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Aug 4, 2020
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
This looks good to me.
I think we should hold off merging non-critical PR's until after Medalla launch, so will wait a few days before merging this.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
## Issue Addressed #1028 A bit late, but I think if `BlockError` had a kind (the current `BlockError` minus everything on the variants that comes directly from the block) and the original block, more clones could be removed
|
Pull request successfully merged into master. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#1028
A bit late, but I think if
BlockErrorhad a kind (the currentBlockErrorminus everything on the variants that comes directly from the block) and the original block, more clones could be removed