[Merged by Bors] - Process gossip blocks on the GossipProcessor #1523
Conversation
paulhauner
added
ready-for-review
| block: Box<SignedBeaconBlock<E>>, | ||
| ) -> Self { | ||
| Self { | ||
| drop_during_sync: true, |
There was a problem hiding this comment.
Are we confident that sync can handle getting to the head reliably without the help of gossip blocks? I thought I'd noticed that my node sometimes got kicked out of a sync loop by a new gossip block
There was a problem hiding this comment.
Oh yeah. So there is a heuristic where we look at gossip blocks even when we are still synced. If it is close to head its valuable.
See this condition: https://github.com/sigp/lighthouse/blob/master/beacon_node/network/src/sync/manager.rs#L453
There was a problem hiding this comment.
As discussed offline with @AgeManning, I've changed it to always process gossip blocks, even if syncing.
|
All comments addressed except for the one for @AgeManning. I'll await his response, perhaps you could approve pending his approval? :) |
|
bors r+ |
## Issue Addressed NA ## Proposed Changes Moves beacon block processing over to the newly-added `GossipProcessor`. This moves the task off the core executor onto the blocking one. ## Additional Info - With this PR, gossip blocks are being ignored during sync.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Issue Addressed
NA
Proposed Changes
Moves beacon block processing over to the newly-added
GossipProcessor. This moves the task off the core executor onto the blocking one.Additional Info