[Merged by Bors] - Ensure RUSTFLAGS is passed through on cross compile #1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
ready-for-review
michaelsproul
added
ready-for-merge
Member
Author
|
I think that macos failure will go away when bors runs. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
## Issue Addressed NA ## Proposed Changes Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. ## Additional Info NA
|
Build failed: |
Member
Author
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
## Issue Addressed NA ## Proposed Changes Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. ## Additional Info NA
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
## Issue Addressed NA ## Proposed Changes Tells `cross` (used for cross-compiling) to read the `RUSTFLAGS`env and pass it through during build. This allows us to use `-g` and get debug info. ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Tells
cross(used for cross-compiling) to read theRUSTFLAGSenv and pass it through during build. This allows us to use-gand get debug info.Additional Info
NA