[Merged by Bors] - [Remote signer] Add signer consumer lib #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
force-pushed
the
remote-signer
branch
6 times, most recently
from
0a470a0 to
3d711f0
Compare
ghost
force-pushed
the
remote-signer
branch
3 times, most recently
from
2cd575b to
8cffa0c
Compare
ghost
changed the title
ghost
changed the title
ghost
marked this pull request as ready for review
paulhauner
reviewed
Nov 19, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Nice! Super clean and lots of tests.
Just one question that indicates I might be missing something important.
paulhauner
added
the
waiting-on-author
paulhauner
approved these changes
Nov 19, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Great, I'm happy with this. Looking forward to seeing it linked into the validator client! 🚀
Approved, pending merge conflict and subsequent CI. Feel free to bors at will :)
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
Adds a library `common/remote_signer_consumer`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a library
common/remote_signer_consumer