Update to latest libp2p via downgrading libp2p to tokio 0.2 #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Despite significant effort, I don't think we can get to tokio 0.3 ourselves and will have to wait for the hyper and warp ecosystem to update themselves. Latest libp2p panics unless we are running a tokio 0.3 executor.
This PR brings us to the latest libp2p by downgrading the latest libp2p back to tokio 0.2 to run with our current executor.
We will have to hold lighthouse at tokio 0.2 until hyper and warp and all our associated deps that depend on hyper and warp (i.e reqwest) have also updated.