Skip to content

Conversation

@kirk-baird
Copy link
Member

@kirk-baird kirk-baird commented Nov 19, 2020

Issue Addressed

Resolves #1333

Proposed Changes

  • Remove deposit_signature_set() function
  • Prevent deposits from being in SignatureSets
  • User Signature.verify() to verify deposit signatures rather than a signature set which uses fast_aggregate_verify()

Additional Info

n/a

Signed-off-by: Kirk Baird <baird.k@outlook.com>
Signed-off-by: Kirk Baird <baird.k@outlook.com>
@kirk-baird kirk-baird added A0 ready-for-review The code is ready for review labels Nov 19, 2020
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very tidy!

bors r+

bors bot pushed a commit that referenced this pull request Nov 20, 2020
## Issue Addressed

Resolves #1333 

## Proposed Changes

- Remove `deposit_signature_set()` function
- Prevent deposits from being in `SignatureSets`
- User `Signature.verify()` to verify deposit signatures rather than a signature set which uses `fast_aggregate_verify()`

## Additional Info

n/a
@bors
Copy link

bors bot commented Nov 20, 2020

@bors bors bot changed the title Ensure deposit signatures do not use aggregate functions [Merged by Bors] - Ensure deposit signatures do not use aggregate functions Nov 20, 2020
@bors bors bot closed this Nov 20, 2020
@paulhauner paulhauner deleted the deposit-signature-checks branch March 17, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0 ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deposit Signature Subgroup Check

3 participants