Skip to content

[Merged by Bors] - Add Content-Type to metrics server #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paulhauner wants to merge 1 commit into from
Closed

[Merged by Bors] - Add Content-Type to metrics server #2019

paulhauner wants to merge 1 commit into from

Conversation

@paulhauner
Copy link
Member

@paulhauner paulhauner commented Nov 30, 2020

Issue Addressed

Proposed Changes

Adds the Content-Type text/plain header as per #2013

Additional Info

NA

@paulhauner paulhauner added work-in-progress PR is a work-in-progress ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 30, 2020
@paulhauner paulhauner marked this pull request as ready for review November 30, 2020 20:13
realbigsean
realbigsean approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean
Copy link
Member

realbigsean commented Nov 30, 2020

Oh this is pointing at stable..

@paulhauner paulhauner changed the base branch from stable to unstable November 30, 2020 22:06
@paulhauner
Copy link
Member Author

paulhauner commented Nov 30, 2020

Thanks @realbigsean! I'm going to block this one until after v1.0.3.

@paulhauner
Copy link
Member Author

paulhauner commented Nov 30, 2020

bors r+

@paulhauner
Copy link
Member Author

paulhauner commented Dec 1, 2020

bors r-

(Attempting to batch)

@bors
Copy link

bors bot commented Dec 1, 2020

Canceled.

@paulhauner
Copy link
Member Author

paulhauner commented Dec 1, 2020

bors r+

bors bot pushed a commit that referenced this pull request Dec 1, 2020
@paulhauner
Add Content-Type to metrics server (#2019)
b8bd80d 
## Issue Addressed

- Resolves #2013

## Proposed Changes

Adds the `Content-Type text/plain` header as per #2013

## Additional Info

NA
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 1, 2020
@bors
Copy link

bors bot commented Dec 1, 2020

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Add Content-Type to metrics server [Merged by Bors] - Add Content-Type to metrics server Dec 1, 2020
@bors bors bot closed this Dec 1, 2020
@AgeManning AgeManning mentioned this pull request Dec 1, 2020
Closed
@paulhauner paulhauner deleted the metrics-header branch January 20, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Content-Type header for metrics

3 participants

@paulhauner @realbigsean