Delete zipped genesis states and build script #2091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing in favour of #2092, as it allows us to use compressed states for future testnets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Delete the zipped genesis states from
eth2_network_config, as they serve no purpose after #2029 accidentally merged the unzipped genesis states into the repo. Presently the unzipping is just causing unnecessary rebuilds, as thegenesis.sszfiles get overwritten each build, making the source directory appear dirty.Additional Info
If we add another testnet in future for which the genesis state is not known, I think it suffices to add an empty
genesis.sszfile initially, and then update it (andgenesis_is_known: true) once genesis is known.