Skip to content

Conversation

@michaelsproul
Copy link
Member

Issue Addressed

Closes #3656

Proposed Changes

  • Replace set-output by $GITHUB_OUTPUT usage
  • Avoid rate-limits when installing protoc by making authenticated requests (continuation of [Merged by Bors] - Ensure protoc is installed for release CI #3621)
  • Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
  • Upgrade macOS-latest to explicit macOS-12 to silence warning
  • Use actions/checkout@v3 and actions/cache@v3 to avoid deprecated NodeJS v12

Additional Info

Can't silence the NodeJS warnings entirely due to #3705. Can fix that in future.

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Nov 9, 2022
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ☺️

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 13, 2022
@michaelsproul
Copy link
Member Author

Thanks!

bors r+

bors bot pushed a commit that referenced this pull request Nov 13, 2022
## Issue Addressed

Closes #3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of #3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to #3705. Can fix that in future.
@bors bors bot changed the title CI gardening maintenance [Merged by Bors] - CI gardening maintenance Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
@michaelsproul michaelsproul deleted the ci-fixups branch November 14, 2022 01:10
macladson pushed a commit to macladson/lighthouse that referenced this pull request Jan 5, 2023
## Issue Addressed

Closes sigp#3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
## Issue Addressed

Closes sigp#3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants