fusaksa-devnet-2 clean up and fixes#7722
Merged
pawanjay176 merged 10 commits intosigp:fusaka-devnet-2from Jul 10, 2025
Merged
Conversation
jimmygchen
added
ready-for-review
jimmygchen
force-pushed
the
bpo-fork-digest-cleanup
branch
from
d8a3429 to
c84b1d3
Compare
6 tasks
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
force-pushed
the
bpo-fork-digest-cleanup
branch
from
98bc903 to
86cebb6
Compare
pawanjay176
reviewed
Jul 10, 2025
pawanjay176
reviewed
Jul 10, 2025
Member
Author
|
@pawanjay176 I've addressed the comments and fixed the tests 🤞 Please re-review, thanks! |
jimmygchen
added
ready-for-review
pawanjay176
reviewed
Jul 10, 2025
| chain_spec.deneb_fork_epoch = Some(Epoch::new(4)); | ||
| chain_spec.electra_fork_epoch = Some(Epoch::new(5)); | ||
| chain_spec.fulu_fork_epoch = Some(Epoch::new(6)); | ||
| chain_spec |
Member
There was a problem hiding this comment.
might be good to assert that the latest fork's fork_epoch is set or we will need to remember to update this for each fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Clean ups for #7655, mostly just adding doc comments and small refactors, no functionality change.
The original PR renamed some of the
fork_*field names todigest_*, e.g.digest_epoch,duration_to_next_digestetc - it reads a bit strange at first, BPO forks are technically still hard forks - I think calling them forks instead of digests are a bit easier to understand. But I'd like to hear thoughts before proceeding with making this change.