Skip to content

Conversation

@AgeManning
Copy link
Member

This just runs cargo update.

One of the updates includes a discovery patch which should fix #8437.

@michaelsproul
Copy link
Member

Looks like there are some deprecations that need fixing (TempDir::into_path).

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. v8.1.0 Post-Fulu release labels Nov 20, 2025
@AgeManning AgeManning requested a review from jxs as a code owner November 24, 2025 03:26
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Nov 24, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependencies via cargo update, which includes a discovery patch intended to fix issue #8437. The changes involve three code files adapting to updated API surfaces, along with extensive dependency version updates in Cargo.lock.

Key changes:

  • Updated test code to use new tempfile API methods (keep() instead of into_path())
  • Updated production code to use new libp2p_mplex API (Config::new() instead of MplexConfig::new())
  • Numerous dependency version updates across the project

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
validator_client/graffiti_file/src/lib.rs Test code updated to use tempfile keep() method instead of into_path()
beacon_node/lighthouse_network/tests/common.rs Test code updated to use tempfile keep() method instead of into_path()
beacon_node/lighthouse_network/src/service/utils.rs Updated to use new libp2p_mplex::Config::new() API
Cargo.lock Extensive dependency version updates including the discovery patch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelsproul
Copy link
Member

Thought copilot might pick up on the duplicate socket2 version introduced in Cargo.lock, but that's fine. It'll go away when everyone updates to 0.6 anyway.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 24, 2025
@mergify mergify bot added the queued label Nov 24, 2025
mergify bot added a commit that referenced this pull request Nov 24, 2025
mergify bot added a commit that referenced this pull request Nov 24, 2025
mergify bot added a commit that referenced this pull request Nov 24, 2025
mergify bot added a commit that referenced this pull request Nov 24, 2025
@mergify mergify bot merged commit 2ba8a8e into sigp:unstable Nov 24, 2025
42 checks passed
@mergify mergify bot removed the queued label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v8.1.0 Post-Fulu release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants