Skip to content

Drop EOL k8s releases v1.31 and v1.32 from policy-controller e2e test status checks#730

Merged
Hayden-IO merged 2 commits into
sigstore:mainfrom
malancas:policy-controller-drop-eol-k8s-verions-from-e2e
Jun 24, 2026
Merged

Drop EOL k8s releases v1.31 and v1.32 from policy-controller e2e test status checks#730
Hayden-IO merged 2 commits into
sigstore:mainfrom
malancas:policy-controller-drop-eol-k8s-verions-from-e2e

Conversation

@malancas

Copy link
Copy Markdown
Contributor

Summary

Dropping EOL k8s releases v1.31 and v.32 from the policy controller e2e test status checks. sigstore/policy-controller#1985 will be merged after this.

Release Note

Documentation

…hecks

Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas malancas requested review from a team as code owners June 23, 2026 22:25
Hayden-IO
Hayden-IO previously approved these changes Jun 24, 2026
@Hayden-IO

Copy link
Copy Markdown
Contributor

Ah, we might need to move off pull request target. I had looked into this previously but couldn't figure out a great way to do so.

@bobcallaway

Copy link
Copy Markdown
Member

Ah, we might need to move off pull request target. I had looked into this previously but couldn't figure out a great way to do so.

not sure that's possible, and the separate of scope b/t data and execution in this and the github-sync project make this safe IMO

@malancas

Copy link
Copy Markdown
Contributor Author

@Hayden-IO Would you mind merging this, I don't have permission. Or do we need deal with the failing CI check first?

@Hayden-IO

Copy link
Copy Markdown
Contributor

Can you add allow-unsafe-pr-checkout: true to the actions/checkout step to fix the PR failure? Though I'm not sure if that'll still fail until it's merged, we'll see.

not sure that's possible, and the separate of scope b/t data and execution in this and the github-sync project make this safe IMO

Yea, I went down a rabbit hole seeing if there was anything we could do to exploit this, didn't find anything obvious. One option would be a maintainer adding a /slash comment that triggers another workflow.

Signed-off-by: Meredith Lancaster <malancas@github.com>
@malancas

Copy link
Copy Markdown
Contributor Author

Can you add allow-unsafe-pr-checkout: true to the actions/checkout step to fix the PR failure? Though I'm not sure if that'll still fail until it's merged, we'll see.

Added the option but the CI check is still failing with the same message unfortunately.

@Hayden-IO

Copy link
Copy Markdown
Contributor

I'm going to merge anyways and run the preview manually, I suspect this will fail until it's merged.

@Hayden-IO Hayden-IO merged commit 16ba4ed into sigstore:main Jun 24, 2026
1 of 2 checks passed
@malancas malancas deleted the policy-controller-drop-eol-k8s-verions-from-e2e branch June 24, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants