build: Switch to uv_build - #1892
Open
jku wants to merge 1 commit into
Open
Conversation
jku
marked this pull request as draft
September 8, 2026 10:00
Switch from flit to uv_build as build backend to remove an additional
dependency. This should also make the build actually reproducable
(since the flit was not strictly pinned)
* stop using dynamic version (not supported by uv): add a build time
check and tweak version test instead to ensure versions match. I did
not use `importlib.metadata.version("sigstore")` to avoid the import
and call on every invocation
* Pin the uv_build version with the `version-file: uv.lock` trick
* Results are basically identical (trivial changes in build metadata)
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
this is likely not that important in practice, I can remove it if there's complaints. I just think build dependency versions should be pinned as strictly as runtime ones. |
jku
marked this pull request as ready for review
September 8, 2026 10:21
Member
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from flit to uv_build as build backend to remove an additional dependency. This should also make the build actually reproducable (since flit was not strictly pinned)
importlib.metadata.version("sigstore")to avoid the import and call on every invocationversion-file: uv.locktrick for build reproducibility: otherwise uv-setup is not very strict about the uv version and will kind of use whatever is available