Use the bare SliceFactory stem for the Avalonia field-control factory

Reviewer chose the bare legacy stem over the qualified RegionSliceFactory, making the FwAvalonia.Region type a deliberate cross-namespace twin of DetailControls.SliceFactory; no CS0104 alias was needed (no site references the bare stem while importing DetailControls), and the engine-isolation audit's source denylist drops SliceFactory since FwAvalonia.Region now owns the twin while the assembly-level guard still enforces isolation; behavior-preserving.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: jasonleenaylor

Src/Common/FwAvalonia/FwAvaloniaTests/EngineIsolationAuditTests.cs

@@ -34,13 +34,17 @@ public class EngineIsolationAuditTests
 		// Identifiers from the forbidden-symbol list that
 		// production source must not name (native Views render/editor pipeline, legacy DataTree/Slice
 		// editor surface, native render engines, browser/PDF engines).
+		// "SliceFactory" is deliberately absent: FwAvalonia.Region owns its own SliceFactory (a
+		// cross-namespace twin of the legacy DetailControls.SliceFactory), so the bare stem is now a
+		// legitimate first-party code symbol. Isolation from the native twin is still enforced by
+		// ProductionAssembly_ReferencesNoNativeRenderLegacyOrDomainAssemblies (DetailControls assembly).
 		private static readonly string[] ForbiddenSourceSymbols =
 		{
 			"IVwRootBox", "IVwEnv", "IVwGraphics", "VwRootBox", "ManagedVwWindow",
 			"IRenderEngine", "IRenderEngineFactory", "GraphiteEngineClass", "UniscribeEngineClass",
 			"FwGrEngine", "GraphiteSegment", "RootSiteControl",
 			"GeckoWebBrowser", "XWebBrowser", "GeckofxHtmlToPdf", "FieldWorksPdfMaker",
-			"DataTree", "Slice", "SliceFactory", "XmlView", "BrowseViewer"
+			"DataTree", "Slice", "XmlView", "BrowseViewer"
 		};
 
 		[Test]
@@ -79,7 +83,7 @@ public void ProductionSource_NamesNoForbiddenNativeRenderSymbols()
 			foreach (var path in sources)
 			{
 				// Comments and string literals are stripped before matching. The DataTree/Slice/
-				// SliceFactory/BrowseViewer parity symbols are legitimately named throughout this
+				// BrowseViewer parity symbols are legitimately named throughout this
 				// codebase's XML-doc comments and diagnostic message text to document exactly which
 				// legacy behavior a migrated code path mirrors; that is
 				// documentation, not a dependency. What this audit must catch is the symbol being

…AvaloniaTests/RegionSliceFactoryTests.cs …nia/FwAvaloniaTests/SliceFactoryTests.csSrc/Common/FwAvalonia/FwAvaloniaTests/RegionSliceFactoryTests.cs renamed to Src/Common/FwAvalonia/FwAvaloniaTests/SliceFactoryTests.cs Src/Common/FwAvalonia/FwAvaloniaTests/RegionSliceFactoryTests.cs renamed to Src/Common/FwAvalonia/FwAvaloniaTests/SliceFactoryTests.cs

@@ -15,12 +15,12 @@ namespace FwAvaloniaTests
 	/// The shared <see cref="RegionFieldKind"/>→control dispatch both the detail-pane region view
 	/// and the browse in-cell editor route through. These pin that one switch produces the right control
 	/// per surviving kind (Text / Chooser / ReferenceVector / Literal / Custom / Unsupported), and that
-	/// the all-nullable <see cref="RegionSliceFactoryContext"/> serves both surfaces — the browse cell
+	/// the all-nullable <see cref="SliceFactoryContext"/> serves both surfaces — the browse cell
 	/// passes null menu/link callbacks and suppresses the WS-abbreviation gutter while the detail pane
 	/// passes the full set — without either surface hand-rolling its own dispatch.
 	/// </summary>
 	[TestFixture]
-	public class RegionSliceFactoryTests
+	public class SliceFactoryTests
 	{
 		private static RegionField Field(RegionFieldKind kind, string selectedOption = null,
 			System.Func<Control> controlFactory = null)
@@ -33,22 +33,22 @@ private static RegionField Field(RegionFieldKind kind, string selectedOption = n
 
 		[AvaloniaTest]
 		public void TextKind_BuildsMultiWsTextField()
-			=> Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.Text), "Auto.Id", null),
+			=> Assert.That(SliceFactory.Build(Field(RegionFieldKind.Text), "Auto.Id", null),
 				Is.InstanceOf<FwMultiWsTextField>());
 
 		[AvaloniaTest]
 		public void ChooserKind_BuildsChooserField()
-			=> Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.Chooser), "Auto.Id", null),
+			=> Assert.That(SliceFactory.Build(Field(RegionFieldKind.Chooser), "Auto.Id", null),
 				Is.InstanceOf<FwChooserField>());
 
 		[AvaloniaTest]
 		public void ReferenceVectorKind_BuildsReferenceVectorField()
-			=> Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.ReferenceVector), "Auto.Id", null),
+			=> Assert.That(SliceFactory.Build(Field(RegionFieldKind.ReferenceVector), "Auto.Id", null),
 				Is.InstanceOf<FwReferenceVectorField>());
 
 		[AvaloniaTest]
 		public void UnsupportedKind_BuildsUnsupportedTextBlock()
-			=> Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.Unsupported), "Auto.Id", null),
+			=> Assert.That(SliceFactory.Build(Field(RegionFieldKind.Unsupported), "Auto.Id", null),
 				Is.InstanceOf<TextBlock>());
 
 		// Literal: a static text renderer (legacy MessageSlice) — the label/message text is the
@@ -62,21 +62,21 @@ public void LiteralKind_BuildsStaticTextBlock_ShowingTheLabel()
 				automationId: "Auto.Lit", localizationKey: null, routing: SurfaceRouting.Product,
 				values: new List<RegionWsValue> { new RegionWsValue("", "Read this carefully:") },
 				options: null, selectedOptionKey: null, isEditable: false);
-			var control = RegionSliceFactory.Build(field, "Auto.Lit", null);
+			var control = SliceFactory.Build(field, "Auto.Lit", null);
 			Assert.That(control, Is.InstanceOf<TextBlock>());
 			Assert.That(((TextBlock)control).Text, Is.EqualTo("Read this carefully:"));
 		}
 
 		[AvaloniaTest]
 		public void CustomKind_NullFactory_DegradesToUnsupportedRow()
-			=> Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.Custom, controlFactory: null),
+			=> Assert.That(SliceFactory.Build(Field(RegionFieldKind.Custom, controlFactory: null),
 				"Auto.Id", null), Is.InstanceOf<TextBlock>());
 
 		[AvaloniaTest]
 		public void CustomKind_FactoryControl_IsReturned()
 		{
 			var marker = new Border();
-			var control = RegionSliceFactory.Build(
+			var control = SliceFactory.Build(
 				Field(RegionFieldKind.Custom, controlFactory: () => marker), "Auto.Id", null);
 			Assert.That(control, Is.SameAs(marker));
 		}
@@ -86,9 +86,9 @@ public void BrowseStyleContext_TextField_SuppressesWritingSystemAbbreviation()
 		{
 			// The dense browse cell context (null callbacks, no abbreviation gutter) must still build a
 			// usable text field — the same control the detail pane gets, just configured for the cell.
-			var browseContext = new RegionSliceFactoryContext(
+			var browseContext = new SliceFactoryContext(
 				editContext: null, writingSystemFocused: _ => { }, showWritingSystemAbbreviation: false);
-			Assert.That(RegionSliceFactory.Build(Field(RegionFieldKind.Text), "Auto.Id", browseContext),
+			Assert.That(SliceFactory.Build(Field(RegionFieldKind.Text), "Auto.Id", browseContext),
 				Is.InstanceOf<FwMultiWsTextField>());
 		}
 	}

Src/Common/FwAvalonia/Region/RegionDataTree.cs

@@ -576,11 +576,11 @@ private sealed class CollapsibleHeader
 		}
 
 		// The field→control dispatch is shared with the browse in-cell editor through
-		// RegionSliceFactory. The detail pane passes its full callback set (per-WS keyboard, slice
+		// SliceFactory. The detail pane passes its full callback set (per-WS keyboard, slice
 		// menu, link, clipboard) and routes reference-vector gesture completion to its validation-gated
 		// OnSave (the autosave). New RegionFieldKinds are added once, in the factory.
 		private Control BuildEditor(RegionField field, string automationId)
-			=> RegionSliceFactory.Build(field, automationId, new RegionSliceFactoryContext(
+			=> SliceFactory.Build(field, automationId, new SliceFactoryContext(
 				editContext: _editContext,
 				writingSystemFocused: _writingSystemFocused,
 				menuRequested: _menuRequested,

…/FwAvalonia/Region/RegionSliceFactory.cs …Common/FwAvalonia/Region/SliceFactory.csSrc/Common/FwAvalonia/Region/RegionSliceFactory.cs renamed to Src/Common/FwAvalonia/Region/SliceFactory.cs Src/Common/FwAvalonia/Region/RegionSliceFactory.cs renamed to Src/Common/FwAvalonia/Region/SliceFactory.cs

@@ -15,15 +15,15 @@ namespace SIL.FieldWorks.Common.FwAvalonia.Region
 {
 	/// <summary>
 	/// The small bundle of (all-nullable) collaborators a <see cref="RegionFieldKind"/> editor needs,
-	/// passed to <see cref="RegionSliceFactory.Build"/> so the SAME field→control dispatch serves
+	/// passed to <see cref="SliceFactory.Build"/> so the SAME field→control dispatch serves
 	/// every hosting surface (today the detail-pane region view, <c>RegionDataTree.BuildEditor</c>;
 	/// any future in-cell editor passes only the collaborators it has). Every member is optional: a null
 	/// edit context yields read-only display; a null callback simply disables that affordance.
 	/// One switch, so new kinds live in one place.
 	/// </summary>
-	public sealed class RegionSliceFactoryContext
+	public sealed class SliceFactoryContext
 	{
-		public RegionSliceFactoryContext(
+		public SliceFactoryContext(
 			IRegionEditContext editContext = null,
 			Action<string> writingSystemFocused = null,
 			Action<RegionMenuRequest> menuRequested = null,
@@ -76,15 +76,15 @@ public RegionSliceFactoryContext(
 	/// (<c>EditableCellHost.Activate</c>, a 2-kind Chooser/Text subset) both route here rather than
 	/// hand-rolling their own dispatch, so adding a kind (or changing how a kind is built) happens once.
 	/// The factory is pure (static) — all per-surface variation arrives through the
-	/// <see cref="RegionSliceFactoryContext"/>.
+	/// <see cref="SliceFactoryContext"/>.
 	/// </summary>
-	public static class RegionSliceFactory
+	public static class SliceFactory
 	{
 		public static Control Build(RegionField field, string automationId,
-			RegionSliceFactoryContext context)
+			SliceFactoryContext context)
 		{
 			if (field == null) throw new ArgumentNullException(nameof(field));
-			context = context ?? new RegionSliceFactoryContext();
+			context = context ?? new SliceFactoryContext();
 
 			switch (field.Kind)
 			{