Audit PR comments: strip migration framing, doc markers, and absence notes

Comment-only pass over the PR's added/changed code comments against the
revised review standard. No behavior change.

- Migration phase/stage framing stripped: "Phase N", "Stage N",
  "MSA-port Stage N", "Phase-1 §19b Stage N", "DATA-SAFETY (Phase 1, test a)"
  and similar temporal-position/future-stage prefixes and dividers; surviving
  behavior text kept and re-evaluated, comments with only process removed.
- Internal-doc and section markers removed: design/skill .md filenames
  (winforms-free-lexeme-editor.md, canonical-view-definition-design.md,
  dialog-ownership.md, native-views-audit.md, etc.) and pointers into them
  (§19a-§19g, §20.x, §8.3, D1/D3, F-1/F-7, LE-4, T-rubric tags, "task N.N",
  "(6.3/B8)", "(B7)", "19i.x"). Genuine WHY rewritten self-contained.
  LT-##### Jira refs preserved.
- Absence/stale narration deleted or rephrased to current fact
  ("no longer forces read-only" -> "does not force read-only";
  "replacement for the old detached DTO mapping" clause dropped).
- Creation-process / forward-work removed ("is deferred", "once other tools
  are wired", "before a second region reuses this", review-cleanup notes).
- Legacy temporal framing trimmed to plain current behavior; legacy parity
  WHY (naming the legacy equivalent) kept.
- String literals, code identifiers (e.g. Phase1FollowUpSurfaceTools),
  and pre-existing legacy comments left untouched.

Build: build.ps1 -SkipNative -BuildTests -> 0 errors, 0 warnings.
Tests: FwAvaloniaTests 634 (633 pass / 1 skip); FwAvaloniaDialogsTests 298/298.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: jasonleenaylor

Src/Common/Controls/DetailControls/DetailControlsTests/DataTreeDisposalCharacterizationTests.cs

@@ -13,12 +13,11 @@ namespace SIL.FieldWorks.Common.Framework.DetailControls
 {
 	/// <summary>
 	/// Characterization tests that lock down the CURRENT disposal, event-unsubscription, focus, and
-	/// accessibility behavior of <see cref="DataTree"/> and <see cref="Slice"/> BEFORE the Avalonia
-	/// refactor (task 2.7 of lexical-edit-avalonia-migration). These protect the refactor: an Avalonia
-	/// adapter selected by the two-adapter flag must preserve this observable behavior.
+	/// accessibility behavior of <see cref="DataTree"/> and <see cref="Slice"/>. The Avalonia editors
+	/// that replace these controls must preserve this observable behavior.
 	///
 	/// They assert observable behavior only (IsDisposed, no-throw after Dispose, AccessibleName,
-	/// focus order) so they remain robust across the refactor rather than pinning private internals.
+	/// focus order) so they remain robust rather than pinning private internals.
 	/// </summary>
 	[TestFixture]
 	public class DataTreeDisposalCharacterizationTests : MemoryOnlyBackendProviderRestoredForEachTestTestBase

Src/Common/Controls/DetailControls/DetailControlsTests/DataTreeReshowTimingTests.cs

@@ -15,11 +15,10 @@
 namespace SIL.FieldWorks.Common.Framework.DetailControls
 {
 	/// <summary>
-	/// Task 2.13 (refresh-after-edit path): measures the legacy DataTree's re-show cost — a second
-	/// <c>ShowObject</c> on the live tree after a model edit, which exercises the slice-reuse
-	/// (ObjSeqHashMap) refresh path RecordEditView drives on record navigation and refresh. Numbers
-	/// accumulate into the same <c>Output/RenderBenchmarks/datatree-timings.json</c> artifact the
-	/// entry-open baselines use and feed region-manifest §5.
+	/// Measures the legacy DataTree's re-show cost — a second <c>ShowObject</c> on the live tree after
+	/// a model edit, which exercises the slice-reuse (ObjSeqHashMap) refresh path RecordEditView drives
+	/// on record navigation and refresh. Numbers accumulate into the same
+	/// <c>Output/RenderBenchmarks/datatree-timings.json</c> artifact the entry-open baselines use.
 	/// </summary>
 	[TestFixture]
 	public class DataTreeReshowTimingTests : MemoryOnlyBackendProviderRestoredForEachTestTestBase

Src/Common/Controls/DetailControls/DetailControlsTests/DataTreeUndoRedoCharacterizationTests.cs

@@ -14,11 +14,10 @@ namespace SIL.FieldWorks.Common.Framework.DetailControls
 {
 	/// <summary>
 	/// Characterization tests that lock down the CURRENT undo/redo transaction behavior for the
-	/// editor-replacement candidate fields shown by <see cref="DataTree"/> (task 2.6 of
-	/// lexical-edit-avalonia-migration). They assert on the LCModel source of truth and the action
-	/// handler's undo/redo state, which is framework-neutral: the Avalonia editors must commit through
-	/// the same fenced LCModel transactions (see avalonia-edit-sessions / avalonia-undo-redo) and
-	/// therefore reproduce exactly these undo/redo results.
+	/// editor-replacement candidate fields shown by <see cref="DataTree"/>. They assert on the LCModel
+	/// source of truth and the action handler's undo/redo state, which is framework-neutral: the
+	/// Avalonia editors must commit through the same fenced LCModel transactions and therefore
+	/// reproduce exactly these undo/redo results.
 	///
 	/// Pattern: the test base opens an ambient undo task during setup; we close it with
 	/// <c>m_actionHandler.EndUndoTask()</c>, then make discrete undoable edits via

Src/Common/Controls/DetailControls/DetailControlsTests/RenderFailureArtifactBundlerTests.cs

@@ -9,9 +9,9 @@
 namespace SIL.FieldWorks.Common.Framework.DetailControls
 {
 	/// <summary>
-	/// Tests for <see cref="RenderFailureArtifactBundler"/> (task 2.5): on a failed render/parity
-	/// verification, the bundler must gather the available artifacts and a summary into one
-	/// CI-discoverable folder, and must be a no-op for a passing result.
+	/// Tests for <see cref="RenderFailureArtifactBundler"/>: on a failed render/parity verification,
+	/// the bundler must gather the available artifacts and a summary into one CI-discoverable folder,
+	/// and must be a no-op for a passing result.
 	/// </summary>
 	[TestFixture]
 	public class RenderFailureArtifactBundlerTests

Src/Common/Framework/MainWindowDelegate.cs

@@ -680,14 +680,13 @@ public bool ShowStylesDialog(string paraStyleName, string charStyleName,
 				GetStyleNames(ActiveView as SimpleRootSite, EditingHelper.CurrentSelection.Selection,
 					ref paraStyleName, ref charStyleName);
 			}
-			// PARITY §19g: the Styles dialog (FwStylesDlg) is NOT migrated to the Avalonia dialog
+			// PARITY: the Styles dialog (FwStylesDlg) is NOT migrated to the Avalonia dialog
 			// kit. It hosts an IVwRootSite/SimpleRootSite (the live style PREVIEW pane renders through the
 			// Views engine — see the activeViewSite argument and the GetStyleNames selection walk above), which
-			// the dialog-kit hard rule (dialog-conversion.md §0) explicitly routes to the document engine
-			// (Stage 9), not this hand-authored MVVM kit. §19c ships named-style APPLY over a
-			// host-supplied style list (the common "set this run's style" path); authoring/managing the styles
-			// themselves needs the Views-engine preview and stays on the legacy WinForms dialog below until
-			// Stage 9.
+			// the dialog-kit hard rule explicitly routes to the document engine,
+			// not this hand-authored MVVM kit. Named-style APPLY over a
+			// host-supplied style list (the common "set this run's style" path) is available; authoring/managing the styles
+			// themselves needs the Views-engine preview and stays on the legacy WinForms dialog below.
 			using (FwStylesDlg stylesDlg = new FwStylesDlg(activeViewSite,
 				Cache, ActiveStyleSheet, (vc == null) ? false : vc.RightToLeft,
 				Cache.ServiceLocator.WritingSystems.AllWritingSystems.Any(ws => ws.RightToLeftScript),

Src/Common/FwAvalonia/AvaloniaDialogHost.cs

@@ -14,7 +14,7 @@ namespace SIL.FieldWorks.Common.FwAvalonia
 	/// <summary>
 	/// Reusable host that shows an Avalonia dialog body (a <c>UserControl</c>) inside a WinForms-owned
 	/// modal <see cref="Form"/> during coexistence — the turn-key piece for the MVVM dialog kit. Because
-	/// Avalonia modal windows are not supported while WinForms owns the message loop (dialog-ownership.md),
+	/// Avalonia modal windows are not supported while WinForms owns the message loop,
 	/// the dialog body is hosted in a WinForms modal window owned by the caller's form; the view-model
 	/// closes it by raising <see cref="IDialogViewModel.CloseRequested"/> (no windowing in the VM).
 	///
@@ -54,8 +54,8 @@ public static class AvaloniaDialogHost
 			if (dialogBody == null) throw new ArgumentNullException(nameof(dialogBody));
 			if (viewModel == null) throw new ArgumentNullException(nameof(viewModel));
 
-			// Modal hosting + Avalonia share the single WinForms UI thread / message loop during coexistence
-			// (dialog-ownership.md). Showing a modal Form or touching Avalonia controls off that thread is a
+			// Modal hosting + Avalonia share the single WinForms UI thread / message loop during coexistence.
+			// Showing a modal Form or touching Avalonia controls off that thread is a
 			// re-entrancy/cross-thread bug; fail fast rather than corrupt the message loop. The owner control
 			// (when supplied) is the WinForms host whose thread we must be on.
 			if (owner is Control ownerControl && ownerControl.InvokeRequired)
@@ -68,7 +68,7 @@ public static class AvaloniaDialogHost
 			// roomy Fluent defaults. Applied here (the single dialog chokepoint) so new dialogs inherit it.
 			CompactDialogStyles.Apply(dialogBody);
 
-			// dialog-ownership.md: remember the WinForms focus so it returns to the owner after close.
+			// Remember the WinForms focus so it returns to the owner after close.
 			var priorFocus = Form.ActiveForm?.ActiveControl;
 
 			try
@@ -97,7 +97,7 @@ public static class AvaloniaDialogHost
 					FwAvaloniaPlatform.GuardHeadlessEmbed(host);
 					form.Controls.Add(host);
 
-					// A11Y-03 (legacy WinForms parity): focus the first input when the dialog opens so a
+					// Legacy WinForms parity: focus the first input when the dialog opens so a
 					// keyboard / screen-reader user lands in a field, not on an unfocused window (and, with
 					// the per-view TabIndex, not on the OK/Cancel strip). Done on Shown so the hosted Avalonia
 					// content is realized. Best-effort: a no-op if nothing qualifies (never throws).
@@ -238,7 +238,7 @@ public static void ApplySizing(
 
 		/// <summary>
 		/// Focuses the first keyboard-focusable INPUT inside <paramref name="dialogBody"/> so a dialog opens
-		/// with the caret in its first field (legacy WinForms parity; A11Y-03). Buttons (OK/Cancel/Help) are
+		/// with the caret in its first field (legacy WinForms parity). Buttons (OK/Cancel/Help) are
 		/// never the initial focus — initial focus belongs to an input, and Enter/Escape already activate the
 		/// default/cancel buttons. Returns the control it focused, or null if none qualifies. Factored out
 		/// (like <see cref="ApplySizing"/> / <see cref="WireClose"/>) so the selection contract is unit-testable

Src/Common/FwAvalonia/AvaloniaRegionHostControl.cs

@@ -12,12 +12,11 @@
 namespace SIL.FieldWorks.Common.FwAvalonia
 {
 	/// <summary>
-	/// Reusable WinForms host for an Avalonia region surface (Stage 2.1: generalized out of
-	/// <see cref="LexicalEditHostControl"/> so a second region host does not re-derive the in-process
-	/// net48 plumbing). Owns Avalonia bootstrap, the <see cref="WinFormsAvaloniaControlHost"/>, the
-	/// companion-control strip, the WinForms/Avalonia directional-key interop, focus-safe content
-	/// swapping, context menus, and the message/clear states. Region-specific projection (building the
-	/// region view) belongs to the derived class via <see cref="SetRegionContent"/>.
+	/// Reusable WinForms host for an Avalonia region surface. Owns Avalonia bootstrap, the
+	/// <see cref="WinFormsAvaloniaControlHost"/>, the companion-control strip, the WinForms/Avalonia
+	/// directional-key interop, focus-safe content swapping, context menus, and the message/clear
+	/// states. Region-specific projection (building the region view) belongs to the derived class
+	/// via <see cref="SetRegionContent"/>.
 	/// </summary>
 	public abstract class AvaloniaRegionHostControl : System.Windows.Forms.UserControl
 	{
@@ -76,7 +75,7 @@ protected void SetHostContent(Avalonia.Controls.Control content)
 		protected Avalonia.Controls.Control CurrentContent => Host.Content as Avalonia.Controls.Control;
 
 		/// <summary>
-		/// §19d: the current hosted Avalonia content (public accessor), so the product host can resolve the
+		/// The current hosted Avalonia content (public accessor), so the product host can resolve the
 		/// surface's <c>TopLevel</c>/<c>IStorageProvider</c> for the managed file picker the picture media
 		/// seam uses. Null when no content is shown.
 		/// </summary>

Src/Common/FwAvalonia/CompactDialogStyles.cs

@@ -34,7 +34,7 @@ public static class CompactDialogStyles
 		/// <summary>Min height for compact line controls (buttons/combos/text boxes), vs the Fluent ~32px floor.
 		/// Genuine WinForms line controls run 20-23px, but that falls below the ~24px desktop pointer-target
 		/// accessibility floor, so 24 is used instead (see the note on <c>DialogMinControlHeight</c> in
-		/// DialogTheme.axaml and the "Dialog spacing tokens" note in style-system.md).
+		/// DialogTheme.axaml).
 		/// Mirrors <c>DialogMinControlHeight</c> in DialogTheme.axaml.</summary>
 		public const double LineControlMinHeight = 24.0;