LT-18767 yellow box crash in HC for bad XAmple-style reduplication #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I7b4718674ee25850ac760288665c96fdc6bcc71d
Change-Id: I16a6aa014b4f146b70146a9bd70b1ddaf6da922d
jasonleenaylor
approved these changes
Jun 27, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One project got a Yellow Crash box with Hermit Crab. It was due to a mismatch between a partial reduplication pattern and its environment (using the XAmple-style pattern where natural classes are indexed). In this case, the form was
[C^1][V^1][C^2][C^3]
and the environment was
/[C^1][V^1][C^2]h_
Either the form needed to not have [C^3] or the environment needed to have an instance of [C^3].
The fix is to have HCLoader.cs check for any missing piece and ignore it. The fix also creates an error message which shows in Try a Word.
This change is