Skip to content

Conversation

@mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Dec 10, 2025

Implement WarnUserAboutFailedLiftImportIfNecessary in Pub/Sub system

Change-Id: I961f82376fc4304b97c912abbc9808a048afa5d3


This change is Reviewable

Implement WarnUserAboutFailedLiftImportIfNecessary in Pub/Sub system

Change-Id: I961f82376fc4304b97c912abbc9808a048afa5d3
Copy link
Contributor

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aror92 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil)


Src/Common/FieldWorks/FieldWorks.cs line 467 at r1 (raw file):

		private static void WarnUserAboutFailedLiftImportIfNecessary(FwApp fwApp)
		{
			var mainWindow = fwApp.ActiveMainWindow as IFwMainWnd;

Is mainWindow needed anymore here? It looks like this line could be deleted

Change-Id: I7deb9dd3fd4864561c38d4d39ddbfbe49125c6be
Copy link
Contributor Author

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @aror92)


Src/Common/FieldWorks/FieldWorks.cs line 467 at r1 (raw file):

Previously, aror92 (Ariel Ror.) wrote…

Is mainWindow needed anymore here? It looks like this line could be deleted

Done.

Copy link
Contributor

@aror92 aror92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@aror92 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mark-sil)

@mark-sil mark-sil merged commit 7110eff into release/9.3 Dec 11, 2025
5 checks passed
@mark-sil mark-sil deleted the LT-21488 branch December 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants