Better Style Import and Export (a step toward LT-20393) #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Style import expects a missing `structure` attribute for StructureValues.Undefined. Change-Id: I76fd619e53e3bc660aa9c7ff638bb3f814346d1b
jasonleenaylor
approved these changes
Jan 8, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @papeh).
The initial fix to LT-20393 caused a regression with the same steps as LT-20895. Fix the style export update so that the legacy style import continues to work. Also: * Modernize the import * Update a message about the installation CD * Fix incorrect exception messages regarding the import Change-Id: I7b6e120246cce9614d1a88a8a42b9145d61d5841
* Remove some TE-specific code * Fix the comment on EnsureCompatibleFactoryStyle Change-Id: I610d98564e14c36eb9f2e9a9f28d62acf59219c5
Change-Id: Ia02602d5162747fe480723a6515b1ffcacbeb3e9
Change-Id: I5254909decfc953fd9fa157b8c768d8efd214000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future work: restore deleted Styles on failed import, or update the import code to leave existing styles in place (and handle imports of installed vs. user-defined styles differently)
This change is