Fix LT-22352: Crash after clicking Merge Sense in popup window #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papeh
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22352. The problem is that the Lexicon Edit Popup window sends the message "DataTreeMerge" expecting only the lexicon edit pane to receive it, but the Word Analyses pane also gets the message and crashes. I changed OnDataTreeMerge to return false in this case.
This could be a general problem with invoking commands on the Lexicon Edit Popup window since the Lexicon Edit Popup window can be in a lot of different environments than the Lexicon Edit pane. I couldn't think if a general solution.
This change is