Skip to content

LT-21495: Move AddTexts to Pub/Sub#736

Merged
mark-sil merged 1 commit intomainfrom
LT-21495
Mar 4, 2026
Merged

LT-21495: Move AddTexts to Pub/Sub#736
mark-sil merged 1 commit intomainfrom
LT-21495

Conversation

@mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Mar 4, 2026

Cherry-pick from the PubSub branch to the main branch using the following commands:
git cherry-pick --no-commit 11d9885
git cherry-pick --no-commit d431877

After the cherry-pick additional edits were made to:

  1. resolve conflicts
  2. Remove the Subscribe() and Unsubscribe() from StatisticsView.cs. In this view the command is only executed from the menu and toolbar. The GUI that would call Publish() is not displayed.
  3. standardize on the use of: using static SIL.FieldWorks.Common.FwUtils.FwUtils;

This change is Reviewable

Cherry-pick from the PubSub branch to the main branch using
the following commands:
git cherry-pick --no-commit 11d9885
git cherry-pick --no-commit d431877

After the cherry-pick additional edits were made to:
1. resolve conflicts
2. Remove the Subscribe() and Unsubscribe() from
StatisticsView.cs. In this view the command is only executed
from the menu and toolbar. The GUI that would call Publish()
is not displayed.
3. standardize on the use of:
using static SIL.FieldWorks.Common.FwUtils.FwUtils;
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   5m 56s ⏱️ +8s
4 407 tests ±0  4 320 ✅ ±0  87 💤 ±0  0 ❌ ±0 
4 416 runs  ±0  4 329 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 39ef533. ± Comparison against base commit fe415b8.

@jasonleenaylor
Copy link
Contributor

Src/xWorks/RecordClerk.cs line 2017 at r1 (raw file):

		/// Stop notifications of prop changes
		/// </summary>
		protected virtual void RemoveNotification()

All this looks good so long as RemoveNotification is called when RecordClerk is disposed.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mark-sil).

@mark-sil mark-sil merged commit cbc9499 into main Mar 4, 2026
7 checks passed
@mark-sil mark-sil deleted the LT-21495 branch March 4, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants