Fix LT-22295: Crash when switching to Texts and Words#739
Merged
jtmaxwell3 merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
NUnit Tests 1 files 1 suites 5m 45s ⏱️ Results for commit 677cb7a. ♻️ This comment has been updated with latest results. |
papeh
reviewed
Mar 17, 2026
| SetFocusBoxSizeForVc(); | ||
| try | ||
| { | ||
| // Don't let the FocusBox be disposed in VwDrawRootBufferedClass.Create() |
Contributor
There was a problem hiding this comment.
The wording in your commit comment is clearer than this comment. This comment could begin, "Suppress changes to prevent FocusBox from being disposed...." or similar
| get { return false; } | ||
| } | ||
|
|
||
| public bool SuppressChanges = false; |
jasonleenaylor
approved these changes
Mar 17, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Can't come up with a better answer in sort order, so :LGETM:
@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on jtmaxwell3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22295. Calling FocusBox.SelectOccurrence caused the FocusBox to be disposed when VwDrawRootBufferedClass.Create was called in SimpleRootSite.MakeRoot because the RTL property of the selected word was different from the default RTL property. Suppressing this change temporarily avoids the crash. I believe that the change will happen when the window is refreshed.
This change is