Conversation
* Pin patch installer builds to base build-1387 * Clone genericinstaller with other installer deps * Split Malayalam and Yoruba into separate components
* Copy local LCM between restore and build * Consolidate MsBuildArgs construction for main and installer builds * Prevent collisions with -LogFile and -binaryLogger * Split out test running from the main build in patch-installer-cd.yml TODO: split test running in base-installer-cd.yml
|
The following is some prompting from AI - it had a lot of good to say, but I will scope it down to the issues that it thought remained. I am also ignoring all Wix6 things right now - that is the next phase: Required Followup
Items Not Addressed (Track Separately)
Review NotesThe Append git diff --ignore-all-space main -- Build/Installer.targets |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 36 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
FLExInstaller/CustomFeatures.wxi line 30 at r1 (raw file):
<Feature Id="Malay" Title="Malay" Description="Allows the software to have a Malay user interface." Display="expand" Level="1" AllowAdvertise="no"> <Condition Level="1">UserLanguageID = 1086</Condition> <!-- REVIEW (Hasso) 2026.03: ms and zlm are both Malay. Why are we including both? -->
We are including both because users may legitimately have their windows system to either of these and we don't want to force them to switch it.
build.ps1 -RunTests and test.ps1 both fail; revert to the old way of running tests for now to get builds working. This partially reverts commit cb276a1.
build.ps1 -RunTests and test.ps1 both fail; revert to the old way of running tests for now to get builds working. This partially reverts commit cb276a1.
Changes
Required Followup
Patch installer builds will need to be pinned to a new base build that includes the Malayalam and Yoruba installer components.
This change is