Skip to content

LT-22446: Polish Installer Builds#744

Merged
papeh merged 6 commits intomainfrom
fix/installers
Mar 6, 2026
Merged

LT-22446: Polish Installer Builds#744
papeh merged 6 commits intomainfrom
fix/installers

Conversation

@papeh
Copy link
Copy Markdown
Contributor

@papeh papeh commented Mar 6, 2026

Changes

  • Pin patch installer builds to base build-1387
  • Prevent collisions with -LogFile and -binaryLogger (Solution and Installer builds produce separate log files)
  • Split Malayalam and Yoruba into separate installer components
  • Clone genericinstaller with other installer deps
  • Split Malayalam and Yoruba into separate components
  • Move 'Copy local LCM' to between restore and build (so LCM artifacts are available during the build)
  • Consolidate MsBuildArgs construction for main and installer builds
  • Update CD workflows to use new build.ps1 parameters
  • Update LDML Files (a new version was recently released)

Required Followup

Patch installer builds will need to be pinned to a new base build that includes the Malayalam and Yoruba installer components.


This change is Reviewable

papeh added 6 commits March 5, 2026 15:28
* Pin patch installer builds to base build-1387
* Clone genericinstaller with other installer deps
* Split Malayalam and Yoruba into separate components
* Copy local LCM between restore and build
* Consolidate MsBuildArgs construction for main and installer builds
* Prevent collisions with -LogFile and -binaryLogger
* Split out test running from the main build in patch-installer-cd.yml

TODO: split test running in base-installer-cd.yml
@papeh papeh enabled auto-merge (squash) March 6, 2026 17:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   5m 52s ⏱️ +12s
4 407 tests ±0  4 320 ✅ ±0  87 💤 ±0  0 ❌ ±0 
4 416 runs  ±0  4 329 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 2fa8b1b. ± Comparison against base commit 0d6dace.

@johnml1135
Copy link
Copy Markdown
Contributor

The following is some prompting from AI - it had a lot of good to say, but I will scope it down to the issues that it thought remained. I am also ignoring all Wix6 things right now - that is the next phase:

Required Followup

Critical sequencing issue: The ml and yo locale components do not exist in the build-1387 base installer. A patch built against build-1387 that includes these locales will fail because the MSP format requires exact component-level alignment between base and patch. The following steps must happen in order:

  1. Merge this PR.
  2. Trigger a new base installer build from main (producing e.g., build-1390).
  3. Update the patch pin from build-1387build-1390 in a follow-up commit.

Items Not Addressed (Track Separately)

  • Setup-InstallerBuild.ps1 still defaults BaseRelease to build-1188. Update to match the current patch pin.
  • installer-build-guide.md still references build-1188 for patch builds. Update to match.
  • Setup-Developer-Machine.ps1 has a # TODO (Hasso) 2026.03: clone genericinstaller.git (needed for the WiX 3 installer) that is unresolved.
  • No end-to-end patch installer test exists in CI. The patch build can succeed but produce a corrupt .msp if component alignment is off; this is only caught at install time.

Review Notes

The Installer.targets diff is large (~470 lines) due to whitespace normalization (spaces → tabs). The substantive content changes are limited to the addition of ml and yo entries in the L10n file list. Reviewers may find it easier to review with whitespace ignored:

?w=1

Append ?w=1 to the Files Changed URL, or use:

git diff --ignore-all-space main -- Build/Installer.targets

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 36 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on papeh).


FLExInstaller/CustomFeatures.wxi line 30 at r1 (raw file):

		<Feature Id="Malay" Title="Malay" Description="Allows the software to have a Malay user interface." Display="expand" Level="1" AllowAdvertise="no">
			<Condition Level="1">UserLanguageID = 1086</Condition>
			<!-- REVIEW (Hasso) 2026.03: ms and zlm are both Malay. Why are we including both? -->

We are including both because users may legitimately have their windows system to either of these and we don't want to force them to switch it.

@papeh papeh merged commit cb276a1 into main Mar 6, 2026
6 of 7 checks passed
@papeh papeh deleted the fix/installers branch March 6, 2026 21:43
papeh added a commit that referenced this pull request Mar 11, 2026
build.ps1 -RunTests and test.ps1 both fail;
revert to the old way of running tests for now
to get builds working.

This partially reverts commit
cb276a1.
papeh added a commit that referenced this pull request Mar 11, 2026
build.ps1 -RunTests and test.ps1 both fail;
revert to the old way of running tests for now
to get builds working.

This partially reverts commit
cb276a1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants