Fix LT-22465: Missing "Edit Lexical Entry" command#768
Conversation
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
Src/LexText/Interlinear/SandboxBase.ComboHandlers.cs line 2613 at r1 (raw file):
if (m_sandbox.m_hvoLastSelEntry != 0) { return m_caches.MainCache.ServiceLocator.GetInstance<ILexEntryRepository>().GetObject(m_sandbox.m_hvoLastSelEntry);
Are there any concerns with the existing callers to GetLexEntry() expecting null instead of getting this ILexEntry?
|
No. All of the GetLexEntry calls are related to "Edit Lexical Entry...", so they all have the same expectations. |
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 1 file.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
This fixes https://jira.sil.org/browse/LT-22465. The menu has to be rebuilt to include "Edit Lexical Entry" if a lexical entry is added.
This change is