Skip to content

Fix LT-22465: Missing "Edit Lexical Entry" command#768

Merged
jtmaxwell3 merged 1 commit intomainfrom
LT-22465
Mar 17, 2026
Merged

Fix LT-22465: Missing "Edit Lexical Entry" command#768
jtmaxwell3 merged 1 commit intomainfrom
LT-22465

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Collaborator

@jtmaxwell3 jtmaxwell3 commented Mar 17, 2026

This fixes https://jira.sil.org/browse/LT-22465. The menu has to be rebuilt to include "Edit Lexical Entry" if a lexical entry is added.


This change is Reviewable

@github-actions
Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   5m 41s ⏱️ -3s
4 058 tests ±0  3 987 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 067 runs  ±0  3 996 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 78e4bfc. ± Comparison against base commit d58727c.

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).


Src/LexText/Interlinear/SandboxBase.ComboHandlers.cs line 2613 at r1 (raw file):

				if (m_sandbox.m_hvoLastSelEntry != 0)
				{
					return m_caches.MainCache.ServiceLocator.GetInstance<ILexEntryRepository>().GetObject(m_sandbox.m_hvoLastSelEntry);

Are there any concerns with the existing callers to GetLexEntry() expecting null instead of getting this ILexEntry?

@jtmaxwell3
Copy link
Copy Markdown
Collaborator Author

No. All of the GetLexEntry calls are related to "Edit Lexical Entry...", so they all have the same expectations.

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 1 file.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mark-sil made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).

@jtmaxwell3 jtmaxwell3 merged commit f9e8be5 into main Mar 17, 2026
6 of 7 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22465 branch March 17, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants