Skip to content

Fix LT-21583: Create an empty gloss line when approving an analysis#835

Merged
jtmaxwell3 merged 1 commit intomainfrom
LT-21583
Apr 14, 2026
Merged

Fix LT-21583: Create an empty gloss line when approving an analysis#835
jtmaxwell3 merged 1 commit intomainfrom
LT-21583

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Collaborator

@jtmaxwell3 jtmaxwell3 commented Apr 14, 2026

This fixes https://jira.sil.org/browse/LT-21583. It adds a command to create an empty gloss line when approving an analysis. It creates the empty gloss line first because approving the analysis may move it. It doesn't create a gloss line if the analysis already has a gloss. It uses the existing commands for creating an empty gloss line and for approving an analysis.


This change is Reviewable

@github-actions
Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 22s ⏱️ -13s
4 103 tests ±0  4 032 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 112 runs  ±0  4 041 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit fa05c2f. ± Comparison against base commit 2d2ea9c.

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).

@jtmaxwell3 jtmaxwell3 merged commit 6666312 into main Apr 14, 2026
7 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-21583 branch April 14, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants