Fix patch installer after ManagedVwWindow removal#909
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes the Patch Installer’s update-harvest failure after ManagedVwWindow removal by restoring expected base-component placeholders during RescuePatching.
Changes:
- Adds
ManagedVwWindow.dllplaceholder toRescuePatchingremoved-since-base list - Adds
ManagedVwWindow.dll.configplaceholder toRescuePatchingremoved-since-base list - Adds
ManagedVwWindow.pdbplaceholder toRescuePatchingremoved-since-base list
jasonleenaylor
approved these changes
May 22, 2026
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on johnml1135).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManagedVwWindow.dll,ManagedVwWindow.dll.config, andManagedVwWindow.pdbto the existingRescuePatchingplaceholders.PYRO0305because those base components disappeared from the update harvest.Verification
PYRO0305for the threeManagedVwWindowcomponents inPatchableInstaller/CreateUpdatePatch/Master/AppHarvest.wxs.Setup;RescuePatchingand verified all three placeholders were created as zero-byte files underOutput\Release.Build\Agent\Remove-StaleDlls.ps1 -OutputDir "Output\Release" -RepoRoot "." -ReferenceDir "Output\Release" -ValidateOnlyand it accepted the placeholders.CI: Commit messageslocally; no gitlint errors were reported.This change is