Fix LT-22591: Crash in SFM import Modify Mapping dialog#994
Merged
Conversation
This broke during the modernization commit because there was a file to class mismatch and the modern build code expects them to match Rename the files to match the class so the default SDK naming produces the name the runtime requests. This also aligns with the localization build (ProjectLocalizer), which names satellite resources after the resx file: once the translated resx files are renamed on the Crowdin side, this dialog's translations will display for the first time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jtmaxwell3
approved these changes
Jul 6, 2026
jtmaxwell3
left a comment
jtmaxwell3
left a comment
Collaborator
There was a problem hiding this comment.
@jtmaxwell3 partially reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke during the modernization commit because there was a file to class mismatch and the modern build code expects them to match
Rename the files to match the class so the default SDK naming produces the name the runtime requests. This also aligns with the localization build (ProjectLocalizer), which names satellite resources after the resx file: once the translated resx files are renamed on the Crowdin side, this dialog's translations will display for the first time.
This change is