Internalize changes part 1 - #469
Merged
Merged
Conversation
nabalone
changed the title
nabalone
commented
Jul 23, 2026
| setHasRights(false); | ||
| setRecording(false); | ||
| } | ||
| }, [mode]); |
Collaborator
Author
There was a problem hiding this comment.
I might refactor to make these useEffects unnecessary in a future PR
nabalone
force-pushed
the
internalize_changes_part1
branch
from
July 23, 2026 16:44
23882c4 to
38d0415
Compare
Collaborator
Author
|
Collaborator
Author
|
Autocomplete was applied to everywhere this category field was used |
nabalone
force-pushed
the
internalize_changes_part1
branch
from
July 24, 2026 00:20
0485f25 to
38d0415
Compare
Keep the selected resource kind synchronized across mode changes and align upload and record action spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
…rce wizard ref Make SelectArtifactCategory always render the free-solo Autocomplete (type to filter or add a category), dropping the old Select + "add new" menu variant, the now-unused `autocomplete` prop, and its dead helpers. Rename `wizardAddRef` to `isAddingAudioResourceRef` in the desktop and mobile PassageDetail artifacts components for clarity and remove stale TODO comments. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Only pass onSpeaker into MediaUploadContent for Media uploads so Resource/ProjectResource keeps hasRights and the file drop target stays usable. Co-authored-by: Cursor <cursoragent@cursor.com>
Raise the dialog to 700px when space allows, and only pin the record button with space-between in full-height mobile panes. Co-authored-by: Cursor <cursoragent@cursor.com>
Wrap MediaRecord so height:100% cannot resolve against DialogContent and open a gap above the record button. Co-authored-by: Cursor <cursoragent@cursor.com>
Rebasing onto develop left the runtime strings bundle pointing at a stale hash generated before develop's latest strings were merged. Ran the localization updater to regenerate the bundle, pointer, model and reducers from the merged XLIFF so the active bundle matches the source. Verified the regenerated bundle is a superset of develop's strings; the only develop entries not carried over (passageDetailArtifacts.projectResourcePassage, wsAudioPlayer.microphone) are unused in the codebase. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nabalone
force-pushed
the
internalize_changes_part1
branch
from
July 24, 2026 00:29
38d0415 to
8bf2b14
Compare
nabalone
marked this pull request as ready for review
July 24, 2026 00:29
sarahentzel
reviewed
Jul 24, 2026
| scriptureTypeCategory(cat.slug); | ||
| return ( | ||
| // Include the render index so two categories that share a localized | ||
| // name can't collide on the same React key. |
Collaborator
There was a problem hiding this comment.
We shouldn't ever allow a duplicated name...is this covering a possible temporary state?
Collaborator
Author
There was a problem hiding this comment.
I have copied your comment to my next PR (where I have already made a lot of changes to this file), and will address it there if that's okay (#476, NOT yet ready for review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More work on the next step of the dialog, as well as the race condition fix for category addition, will come in another PR.