Skip to content

TT-7431 speaker name chosen mobile - #568

Merged
sarahentzel merged 2 commits into
developfrom
TT-7431
Sep 2, 2026
Merged

TT-7431 speaker name chosen mobile#568
sarahentzel merged 2 commits into
developfrom
TT-7431

Conversation

@sarahentzel

Copy link
Copy Markdown
Collaborator

No description provided.

@sarahentzel
sarahentzel marked this pull request as ready for review September 2, 2026 13:21
@sarahentzel
sarahentzel requested review from gtryus and a lite review from Copilot September 2, 2026 13:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The functional change is small and well-scoped, and the added test provides a regression guard (only minor test cleanup nits noted).

Pull request overview

This PR removes the mobile-specific selection handler from the SpeakerName dialog so speaker selection/add flows use a single code path across form factors, and adds a regression test to ensure the upload speaker field displays the chosen existing speaker name (rights-gated).

Changes:

  • Removed useMobile branching and the separate mobile selection handler in SpeakerName, routing all selections through the unified handleSelectAndClose.
  • Clarified the intent of handleSelectAndClose with updated inline comments.
  • Added a new component-level test covering the “upload speaker field” rights-gated display behavior after selecting an existing speaker.
File summaries
File Description
src/renderer/src/components/SpeakerName.tsx Removes mobile-specific selection logic and uses one selection handler for all views.
src/renderer/src/components/SpeakerName.test.tsx Adds a regression test that selects an existing speaker and asserts the chosen name is shown on the button.
Review details

Suppressed comments (1)

src/renderer/src/components/SpeakerName.test.tsx:76

  • The describe block name still says “(mobile)”, but the component no longer branches on mobile/desktop behavior. Rename the suite so the test description matches what’s actually being tested.
describe('SpeakerName upload dialog (mobile)', () => {
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/renderer/src/components/SpeakerName.test.tsx Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sarahentzel
sarahentzel merged commit ba11329 into develop Sep 2, 2026
2 checks passed
@sarahentzel
sarahentzel deleted the TT-7431 branch September 2, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants