TT-7431 speaker name chosen mobile - #568
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The functional change is small and well-scoped, and the added test provides a regression guard (only minor test cleanup nits noted).
Pull request overview
This PR removes the mobile-specific selection handler from the SpeakerName dialog so speaker selection/add flows use a single code path across form factors, and adds a regression test to ensure the upload speaker field displays the chosen existing speaker name (rights-gated).
Changes:
- Removed
useMobilebranching and the separate mobile selection handler inSpeakerName, routing all selections through the unifiedhandleSelectAndClose. - Clarified the intent of
handleSelectAndClosewith updated inline comments. - Added a new component-level test covering the “upload speaker field” rights-gated display behavior after selecting an existing speaker.
File summaries
| File | Description |
|---|---|
| src/renderer/src/components/SpeakerName.tsx | Removes mobile-specific selection logic and uses one selection handler for all views. |
| src/renderer/src/components/SpeakerName.test.tsx | Adds a regression test that selects an existing speaker and asserts the chosen name is shown on the button. |
Review details
Suppressed comments (1)
src/renderer/src/components/SpeakerName.test.tsx:76
- The describe block name still says “(mobile)”, but the component no longer branches on mobile/desktop behavior. Rename the suite so the test description matches what’s actually being tested.
describe('SpeakerName upload dialog (mobile)', () => {
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.