Skip to content

Migrate test project from VSTest to Microsoft Testing Platform - #101

Merged
hahn-kev merged 3 commits into
sillsdev:mainfrom
hahn-kev-bot:claude/migrate-vstest-to-mtp-klhckk
Aug 7, 2026
Merged

Migrate test project from VSTest to Microsoft Testing Platform#101
hahn-kev merged 3 commits into
sillsdev:mainfrom
hahn-kev-bot:claude/migrate-vstest-to-mtp-klhckk

Conversation

@hahn-kev-bot

@hahn-kev-bot hahn-kev-bot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Switch to the fancy new MTP test runner, instead of vs test.

AI Summary

Switch SIL.Harmony.Tests to run on Microsoft.Testing.Platform (MTP) instead of VSTest, following the .NET VSTest-to-MTP migration guidance.

  • Enable the MTP runner for the xUnit.net v3 test project (UseMicrosoftTestingPlatformRunner + OutputType=Exe).
  • Use the xunit.v3.mtp-v2 package so the GitHubActionsTestLogger MTP extension (which requires MTP v2) can report results in CI.
  • Add global.json with test.runner=Microsoft.Testing.Platform so dotnet test uses MTP on the .NET 10 SDK.
  • Remove VSTest-only packages: Microsoft.NET.Test.Sdk, xunit.runner.visualstudio, coverlet.collector, and the explicit Microsoft.Testing.Platform reference (now transitive).
  • Update CI workflows to replace the VSTest --logger GitHubActions with the MTP --report-github flag.

Claude-Session: https://claude.ai/code/session_01PKdgdJdeDQrwFE5pruMH3n

Summary by CodeRabbit

  • Tests
    • Updated automated test execution to use Microsoft Testing Platform and xUnit v3.
    • Improved GitHub Actions test reporting with the updated test reporting integration.
    • Simplified test project configuration and refreshed test tooling dependencies.
  • Chores
    • Added repository-level configuration for the standardized test runner.

Switch SIL.Harmony.Tests to run on Microsoft.Testing.Platform (MTP)
instead of VSTest, following the .NET VSTest-to-MTP migration guidance.

- Enable the MTP runner for the xUnit.net v3 test project
  (UseMicrosoftTestingPlatformRunner + OutputType=Exe).
- Use the xunit.v3.mtp-v2 package so the GitHubActionsTestLogger MTP
  extension (which requires MTP v2) can report results in CI.
- Add global.json with test.runner=Microsoft.Testing.Platform so
  `dotnet test` uses MTP on the .NET 10 SDK.
- Remove VSTest-only packages: Microsoft.NET.Test.Sdk,
  xunit.runner.visualstudio, coverlet.collector, and the explicit
  Microsoft.Testing.Platform reference (now transitive).
- Update CI workflows to replace the VSTest `--logger GitHubActions`
  with the MTP `--report-github` flag.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PKdgdJdeDQrwFE5pruMH3n
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@hahn-kev-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 72422d70-e201-42a2-afcd-c1c9a96dc906

📥 Commits

Reviewing files that changed from the base of the PR and between d243104 and d08ab9e.

📒 Files selected for processing (1)
  • Directory.Packages.props
📝 Walkthrough

Walkthrough

The test projects now use Microsoft Testing Platform with the xUnit v3 MTP runner. Central test dependencies were updated, and both CI workflows now use --report-github for test reporting.

Changes

Test platform migration

Layer / File(s) Summary
Test runner configuration
global.json, Directory.Packages.props, src/SIL.Harmony.Tests/SIL.Harmony.Tests.csproj
The repository and test project now use Microsoft Testing Platform with the xUnit v3 MTP runner. Legacy test SDK, runner, adapter, coverage, and platform references were removed.
CI test reporting
.github/workflows/test.yaml, .github/workflows/nuget-ci-cd.yml
The test commands now use --report-github instead of the GitHubActions logger option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: hahn-kev, rmunn

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: migrating the test project from VSTest to Microsoft Testing Platform.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

claude added 2 commits August 7, 2026 04:47
…st-to-mtp-klhckk

# Conflicts:
#	Directory.Packages.props
With central transitive pinning enabled (merged from main), the pin must
be >= 2.0.2 to satisfy xunit.v3.core.mtp-v2 3.2.2; 2.0.0 caused an NU1109
package downgrade error on restore.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PKdgdJdeDQrwFE5pruMH3n
@hahn-kev
hahn-kev enabled auto-merge (squash) August 7, 2026 05:41
@hahn-kev
hahn-kev merged commit 09d0eb0 into sillsdev:main Aug 7, 2026
4 checks passed
@hahn-kev-bot
hahn-kev-bot deleted the claude/migrate-vstest-to-mtp-klhckk branch August 7, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants