Render analyzed-token breakdown as a boxed morpheme grid#132
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR moves morpheme gloss editing into a boxed component pair, updates ChangesMorpheme box extraction and integration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant TokenChip
participant MorphemeBox
participant MorphemeGlossInput
participant AnalysisStore
TokenChip->>MorphemeBox: render token morphemes and onEditBreakdown
MorphemeBox->>MorphemeGlossInput: render one gloss input per morpheme
MorphemeGlossInput->>AnalysisStore: read and dispatch gloss updates
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
@alex-rawlings-yyc resolved 2 discussions.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The behavior on this pr is great--well resolves the linked issue. I'll hold off full code review because of the conflicts with |
Extract the morpheme breakdown into a new MorphemeBox component (CSS grid of forms over glosses), simplifying TokenChip and MorphemeEditor accordingly.
Only the first form cell is a real edit-breakdown button; remaining cells are presentational spans (aria-hidden) so assistive tech sees one control for the whole breakdown. Move tw:border-border into the always-on base classes so the open (popover) state keeps an explicit border color instead of falling back to the gray-200 default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
98e4f20 to
95387d8
Compare
Also merge in `main` and fill test coverage.
f51e172 to
94cffa4
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 11 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
94cffa4 to
0427cdb
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
Extract the morpheme breakdown into a new MorphemeBox component (CSS grid of forms over glosses), simplifying TokenChip and MorphemeEditor accordingly.
This change is
Summary by CodeRabbit