Fix gloss-input focus steal on non-first morpheme form cell click#135
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
force-pushed
the
morpheme-box-grid
branch
from
98e4f20 to
95387d8
Compare
Clicking a span (non-first) form cell in MorphemeBox bubbled its mousedown up to TokenChip's label handler, which only recognizes input/button targets and so treated the span as unhandled, focusing the gloss input before the popover opened.
Prior tests only exercised the first (button) form cell; the span cells' click and mousedown-bubbling behavior had no coverage.
alex-rawlings-yyc
left a comment
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
@alex-rawlings-yyc reviewed 25 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
2 participants
Suggested update to #132
Summary
mainMorphemeBoxare presentationalspans (not buttons). A mousedown on one bubbled up toTokenChip's label handler, which only recognizesinput/buttontargets, so it fell through and focused the gloss input before the popover opened — triggering an unintended phrase-centering scroll.🤖 Generated with Claude Code
Devin review: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/135
This change is