Skip to content

Expose SegmentBoundaryAdjuster for external use - #345

Merged
benjaminking merged 4 commits into
mainfrom
expose-segment-boundary-adjuster
Aug 11, 2026
Merged

Expose SegmentBoundaryAdjuster for external use#345
benjaminking merged 4 commits into
mainfrom
expose-segment-boundary-adjuster

Conversation

@benjaminking

@benjaminking benjaminking commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR exposes SegmentBoundaryAdjuster so that it can be used by external callers, specifically the verse segmenter in SILNLP.


This change is Reviewable

@benjaminking
benjaminking requested a review from Enkidu93 August 6, 2026 18:23

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on benjaminking).

@Enkidu93

Copy link
Copy Markdown
Collaborator

@benjaminking, did you already try pushing an empty commit to see if that would trigger the CI?

@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.94%. Comparing base (cfb09c2) to head (d354cfd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         387      387           
  Lines       24380    24381    +1     
=======================================
+ Hits        22415    22416    +1     
  Misses       1965     1965           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I need to put a PR into silnlp to work with the new machine.py API - just so you know: If we release and you try to use this version, python will yell at you a little til that's in.

@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on benjaminking).

@benjaminking benjaminking left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you clarify: what do I need to get in?

@benjaminking made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on benjaminking).

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - to be more specific: The API for the USFM versification warnings has changed, so if we release a new version of machine.py in order to expose the segment boundary adjuster and update silnlp to use the new version, it will break silnlp. I am planning on pushing an update to silnlp soon - it just keeps slipping out of mind.

@Enkidu93 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on benjaminking).

@benjaminking benjaminking left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. I understand now. We can try to coordinate those two changes.

@benjaminking made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on benjaminking).

@benjaminking
benjaminking merged commit deb112b into main Aug 11, 2026
17 checks passed
@benjaminking
benjaminking deleted the expose-segment-boundary-adjuster branch August 11, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants