Update to Machine 3.9.3 - #1038
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 72.75% 72.74% -0.01%
==========================================
Files 392 392
Lines 21711 21711
Branches 2820 2820
==========================================
- Hits 15795 15793 -2
- Misses 4793 4795 +2
Partials 1123 1123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
872f3a0 to
4cc1a17
Compare
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
src/Serval/src/Serval.Translation/Utils/PretranslationConfidenceEvaluator.cs line 1 at r1 (raw file):
using SIL.Machine.QualityEstimation;
Nit: This should be in the global usings.
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 made 1 comment.
Reviewable status: 4 of 9 files reviewed, 1 unresolved discussion.
src/Serval/src/Serval.Translation/Utils/PretranslationConfidenceEvaluator.cs line 1 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Nit: This should be in the global usings.
OK, my instinct was to have it in the global usings, but the other neighboring classes also had their imports from SIL.Machine non-global. I've gone ahead and updated them too.
Also, use new Machine book confidence utility.
This change is