Skip to content

Update to Machine 3.9.3 - #1038

Merged
Enkidu93 merged 5 commits into
mainfrom
machine-3.9.3
Aug 28, 2026
Merged

Update to Machine 3.9.3#1038
Enkidu93 merged 5 commits into
mainfrom
machine-3.9.3

Conversation

@Enkidu93

@Enkidu93 Enkidu93 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Also, use new Machine book confidence utility.


This change is Reviewable

@Enkidu93
Enkidu93 requested review from ddaspit and pmachapman August 28, 2026 16:10
@codecov-commenter

codecov-commenter commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.74%. Comparing base (d6cbc4b) to head (7df82f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   72.75%   72.74%   -0.01%     
==========================================
  Files         392      392              
  Lines       21711    21711              
  Branches     2820     2820              
==========================================
- Hits        15795    15793       -2     
- Misses       4793     4795       +2     
  Partials     1123     1123              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).


src/Serval/src/Serval.Translation/Utils/PretranslationConfidenceEvaluator.cs line 1 at r1 (raw file):

using SIL.Machine.QualityEstimation;

Nit: This should be in the global usings.

@Enkidu93
Enkidu93 merged commit d6a912c into main Aug 28, 2026
1 of 2 checks passed
@Enkidu93
Enkidu93 deleted the machine-3.9.3 branch August 28, 2026 21:13

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Enkidu93 made 1 comment.
Reviewable status: 4 of 9 files reviewed, 1 unresolved discussion.


src/Serval/src/Serval.Translation/Utils/PretranslationConfidenceEvaluator.cs line 1 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Nit: This should be in the global usings.

OK, my instinct was to have it in the global usings, but the other neighboring classes also had their imports from SIL.Machine non-global. I've gone ahead and updated them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants