Skip to content

SF-3851 Fix source tab not being correctly removed on mobile - #4033

Merged
pmachapman merged 1 commit into
masterfrom
fix/SF-3851
Aug 9, 2026
Merged

SF-3851 Fix source tab not being correctly removed on mobile#4033
pmachapman merged 1 commit into
masterfrom
fix/SF-3851

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This PR is still a draft but I am sending it for testing first.


This change is Reviewable

@Nateowami
Nateowami temporarily deployed to screenshot_diff August 7, 2026 03:07 — with GitHub Actions Inactive
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 7, 2026
@Nateowami
Nateowami marked this pull request as ready for review August 7, 2026 15:17
@Nateowami
Nateowami temporarily deployed to screenshot_diff August 7, 2026 15:23 — with GitHub Actions Inactive
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (fe924cd) to head (9d5ebc3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4033   +/-   ##
=======================================
  Coverage   81.05%   81.06%           
=======================================
  Files         660      660           
  Lines       43033    43033           
  Branches     7056     7056           
=======================================
+ Hits        34881    34883    +2     
+ Misses       6981     6979    -2     
  Partials     1171     1171           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-assigned this Aug 9, 2026
@pmachapman
pmachapman self-requested a review August 9, 2026 19:46

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman
pmachapman merged commit e9caf3e into master Aug 9, 2026
28 checks passed
@pmachapman
pmachapman deleted the fix/SF-3851 branch August 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants