Remove redundant types and add specific array-types - #121
Merged
cviebrock merged 2 commits intoJul 30, 2025
Conversation
gauthierm
force-pushed
the
remove-redundany-docblocks
branch
from
July 25, 2025 18:31
82ac4bf to
86b2ce4
Compare
cviebrock
reviewed
Jul 25, 2025
cviebrock
reviewed
Jul 25, 2025
| * @license http://www.opensource.org/licenses/mit-license.html MIT License | ||
| * | ||
| * @property int $id | ||
| * @property ?SwatDate $earned_date |
Contributor
There was a problem hiding this comment.
The @var where the property is defined should be made nullable too, I'd think.
Member
Author
There was a problem hiding this comment.
The column in the DB is non-nullable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
@propertydocblocks in favour of@vardocs. Adds specific array types for local cache arrays.See previous #120
Testing Instructions (optional)
Add step-by-step instructions for testing the PR, if necessary.
Developer Checklist
Before requesting review for this PR, make sure the following tasks are
complete:
Reviewer Checklist
Before merging this PR, make sure the following tasks are complete: