fix(permissions): probe Input Monitoring once per process, not every 15s (#488)#500
Merged
Merged
Conversation
…15s (#488) input_monitoring_runtime_issue() created and tore down a real kCGHIDEventTap on every 15s permission-monitor poll (for users who granted Input Monitoring) just to detect a "granted but unusable" state. That state is fixed for the process lifetime -- it's only cleared by restarting the app -- so re-probing is pointless churn on the system-wide input event path. Before #488's teardown fix this churn leaked taps until the tap table exhausted and keyboard/mouse froze system-wide (WindowServer could crash). Memoize the probe result so it runs exactly once per launch, preserving the diagnostic with zero ongoing churn. Complements the CFMachPortInvalidate teardown fix (#499). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
silverstein
added a commit
that referenced
this pull request
Jul 17, 2026
Patch release. Bugfixes only. - fix(hotkey): stop the system-wide CGEventTap leak — a permission probe created a kCGHIDEventTap every 15s and never invalidated it, exhausting the system tap table and freezing keyboard/mouse (and crashing WindowServer) after the app ran a few hours; quitting Minutes restored performance. Now invalidated on teardown and probed once per process. (#488, #499, #500) - fix(build): pin the Swift helper deployment targets so 0.22.0's native-call-capture helper loads on macOS 15 instead of dyld-aborting. (#494, #497) - fix(core): let `--call` auto-detect PipeWire system-audio sinks on Linux. (#489, thanks @gtheys) - fix(summarize): support the Apple engine for speaker mapping. (#487, #498) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #499. The
CFMachPortInvalidateteardown fix stopped the tap leak; this stops the churn that fed it.What
input_monitoring_runtime_issue()created and tore down a realkCGHIDEventTapon every 15s permission-monitor poll (for users who granted Input Monitoring) to detect a "granted but unusable" state. That state is fixed for the process lifetime — it's only cleared by restarting the app — so re-probing is pointless churn on the system-wide input event path (~5,760 tap create/teardown cycles/day). Before #499's teardown fix, this churn is what leaked taps until the 512-entry table exhausted and keyboard/mouse froze system-wide (with WindowServer crashes).Memoize the probe (
OnceLock) so it runs once per launch, preserving the diagnostic with zero ongoing churn.Why this matters
This is the long-standing "Minutes left open overnight makes the whole machine laggy/frozen; quitting Minutes instantly fixes it; SSH stays fine" report — the taps are on
kCGHIDEventTap, the system-wide HID path. #499 + this fix together fully resolve it.Related: #488, #499.
🤖 Generated with Claude Code