Skip to content

Pick dataset icon based on shape in explorer#1976

Merged
axelboc merged 2 commits into
mainfrom
dataset-icons
Mar 11, 2026
Merged

Pick dataset icon based on shape in explorer#1976
axelboc merged 2 commits into
mainfrom
dataset-icons

Conversation

@axelboc
Copy link
Copy Markdown
Contributor

@axelboc axelboc commented Mar 11, 2026

I went through a lot of icons from multiple icon sets available through React Icons but I think it was worth the effort. The new icons help match silx view more closely:

H5Web before H5Web after Silx
image image image

I keep the "layers" icon for 4D+ datasets:

H5Web Silx
image image

Empty datasets (i.e. with a null shape) now have their own icon as well:

H5Web Silx
image image

We don't currently support array datasets with zero dimensions, but if we do in the future, I think a square brackets icon like [] could work.

@axelboc axelboc requested review from loichuder and t20100 March 11, 2026 13:15
Copy link
Copy Markdown
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy moly, that looks so cool ❤️

@loichuder
Copy link
Copy Markdown
Member

1D and 2D icons could be slightly bigger if that's not too difficult to do

Comment thread packages/app/src/explorer/utils.ts Outdated
@axelboc
Copy link
Copy Markdown
Contributor Author

axelboc commented Mar 11, 2026

1D and 2D icons could be slightly bigger if that's not too difficult to do

I'd have to revert to an custom Icon component instead of a getIcon utility. Possible, but a little more verbose. Let me know if you think it's worth it.

@loichuder
Copy link
Copy Markdown
Member

1D and 2D icons could be slightly bigger if that's not too difficult to do

I'd have to revert to an custom Icon component instead of a getIcon utility. Possible, but a little more verbose. Let me know if you think it's worth it.

Nah, let's leave it like this for now and let's see how it goes first.

@axelboc
Copy link
Copy Markdown
Contributor Author

axelboc commented Mar 11, 2026

/approve

@axelboc
Copy link
Copy Markdown
Contributor Author

axelboc commented Mar 11, 2026

A quick win that got lost in the backlog... 😅

@axelboc axelboc merged commit 6b883b2 into main Mar 11, 2026
13 checks passed
@axelboc axelboc deleted the dataset-icons branch March 11, 2026 13:53
@t20100
Copy link
Copy Markdown
Member

t20100 commented Mar 12, 2026

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants