Pick dataset icon based on shape in explorer#1976
Merged
Merged
Conversation
loichuder
approved these changes
Mar 11, 2026
Member
loichuder
left a comment
There was a problem hiding this comment.
Holy moly, that looks so cool ❤️
Member
|
1D and 2D icons could be slightly bigger if that's not too difficult to do |
loichuder
reviewed
Mar 11, 2026
Contributor
Author
I'd have to revert to an custom |
Member
Nah, let's leave it like this for now and let's see how it goes first. |
Contributor
Author
|
/approve |
Contributor
Author
|
A quick win that got lost in the backlog... 😅 |
Member
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through a lot of icons from multiple icon sets available through React Icons but I think it was worth the effort. The new icons help match
silx viewmore closely:I keep the "layers" icon for 4D+ datasets:
Empty datasets (i.e. with a
nullshape) now have their own icon as well:We don't currently support array datasets with zero dimensions, but if we do in the future, I think a square brackets icon like
[]could work.