Reflection + tag_invoke approach to enable ondemand parsing on simdjson#38
Merged
FranciscoThiesen merged 8 commits intomainfrom Aug 9, 2024
Merged
Conversation
error: out-of-line definition of 'get' does not match any declaration in 'simdjson::fallback::ondemand::value'
45 | simdjson_inline simdjson_result<T> simdjson::ondemand::value::get() noexcept {
|
… for pushable containers. Yet to use reflection in the same style in this branch.
…:get() without success...
…demand_daniel Using reflection for simdjson ondemand daniel
…or now, since the reflection + tag_invoke approach is not yet working for documents.
Member
|
I am studying the whole thing. |
…rk for documents as well.
Member
Author
|
@lemire I've just re-enabled example 2, using the-moisrex latest changes. Everything works as expected (: |
Member
|
@FranciscoThiesen Excellent. |
lemire
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverage the work done by @the-moisrex at simdjson/simdjson#2219
As @lemire noted in the comments of example3.cpp, more changes are needed to make this work for simdjson documents. I plan to take up this work to improve upon this contribution.